Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] test fixes #921

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[WIP] test fixes #921

wants to merge 3 commits into from

Conversation

mgyucht
Copy link
Contributor

@mgyucht mgyucht commented May 15, 2024

Changes

Tests

  • make test passing
  • make fmt applied
  • relevant integration tests applied

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0.98592% with 703 lines in your changes are missing coverage. Please review.

Project coverage is 7.08%. Comparing base (72334ef) to head (e7b55aa).

Files Patch % Lines
...service/catalog/mock_quality_monitors_interface.go 1.24% 398 Missing ⚠️
service/catalog/impl.go 0.00% 58 Missing ⚠️
.../mocks/service/compute/mock_libraries_interface.go 0.00% 47 Missing ⚠️
...ocks/service/catalog/mock_connections_interface.go 0.00% 35 Missing ⚠️
...ervice/serving/mock_serving_endpoints_interface.go 0.00% 32 Missing ⚠️
...ctorsearch/mock_vector_search_indexes_interface.go 0.00% 31 Missing ⚠️
service/compute/api.go 0.00% 19 Missing ⚠️
service/pipelines/model.go 0.00% 19 Missing ⚠️
service/vectorsearch/model.go 0.00% 16 Missing ⚠️
service/serving/model.go 0.00% 10 Missing ⚠️
... and 8 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #921      +/-   ##
========================================
- Coverage   7.09%   7.08%   -0.02%     
========================================
  Files        276     276              
  Lines      64381   64511     +130     
========================================
  Hits        4570    4570              
- Misses     59502   59632     +130     
  Partials     309     309              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants