Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OpenAPI spec #934

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Update OpenAPI spec #934

merged 3 commits into from
Jun 3, 2024

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Jun 3, 2024 •
edited
Loading

Changes

Notable changes:

  • Pagination of account-level storage credentials
  • Add batch get APIs for marketplace listings
  • Rename app deployment method

Tests

  • make test passing
  • make fmt applied
  • relevant integration tests applied

@pietern
Copy link
Contributor Author

pietern commented Jun 3, 2024 •
edited
Loading

Holding off until I can re-generate with the correct OpenAPI commit SHA.

@pietern pietern marked this pull request as ready for review June 3, 2024 09:39
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 243 lines in your changes are missing coverage. Please review.

Project coverage is 7.13%. Comparing base (70fcacb) to head (c1f1154).

Files Patch % Lines
...ental/mocks/service/serving/mock_apps_interface.go 0.00% 60 Missing ⚠️
...alog/mock_account_storage_credentials_interface.go 0.00% 40 Missing ⚠️
...ce/marketplace/mock_consumer_listings_interface.go 0.00% 31 Missing ⚠️
...e/marketplace/mock_consumer_providers_interface.go 0.00% 31 Missing ⚠️
service/catalog/api.go 0.00% 16 Missing ⚠️
service/serving/model.go 0.00% 15 Missing ⚠️
service/marketplace/impl.go 0.00% 14 Missing ⚠️
service/serving/api.go 0.00% 10 Missing ⚠️
service/serving/impl.go 0.00% 8 Missing ⚠️
service/catalog/impl.go 0.00% 4 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@           Coverage Diff            @@
##            main    #934      +/-   ##
========================================
- Coverage   7.13%   7.13%   -0.01%     
========================================
  Files        281     281              
  Lines      64591   64633      +42     
========================================
  Hits        4609    4609              
- Misses     59673   59715      +42     
  Partials     309     309

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pietern pietern added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 134b78e Jun 3, 2024
7 checks passed
@pietern pietern deleted the bump-spec branch June 3, 2024 11:04
pietern added a commit that referenced this pull request Jun 3, 2024
@pietern
Release v0.42.0
9622859 
* Ignore additional flaky test ([#930](#930)).
* Ignore DataPlane Services during generation ([#933](#933)).
* Update OpenAPI spec ([#934](#934)).

API Changes:

 * Changed `List` method for [a.AccountStorageCredentials](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#AccountStorageCredentialsAPI) account-level service to return [catalog.ListAccountStorageCredentialsResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ListAccountStorageCredentialsResponse).
 * Added [catalog.ListAccountStorageCredentialsResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ListAccountStorageCredentialsResponse).
 * Added `TerminationCategory` field for [jobs.ForEachTaskErrorMessageStats](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#ForEachTaskErrorMessageStats).
 * Added [oauth2.DataPlaneInfo](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#DataPlaneInfo).
 * Removed `CreateDeployment` method for [w.Apps](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#AppsAPI) workspace-level service.
 * Added `Deploy` method for [w.Apps](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#AppsAPI) workspace-level service.
 * Added `Mode` field for [serving.AppDeployment](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#AppDeployment).
 * Added `Mode` field for [serving.CreateAppDeploymentRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#CreateAppDeploymentRequest).
 * Added `DataPlaneInfo` field for [serving.ServingEndpointDetailed](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServingEndpointDetailed).
 * Added [serving.AppDeploymentMode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#AppDeploymentMode).
 * Added [serving.ModelDataPlaneInfo](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ModelDataPlaneInfo).

OpenAPI SHA: 37b925eba37dfb3d7e05b6ba2d458454ce62d3a0, Date: 2024-06-03

Dependency updates:

 * Bump golang.org/x/mod from 0.16.0 to 0.17.0 ([#879](#879)).
 * Bump golang.org/x/oauth2 from 0.18.0 to 0.20.0 ([#911](#911)).
 * Bump golang.org/x/net from 0.24.0 to 0.25.0 ([#912](#912)).
 * Bump google.golang.org/api from 0.169.0 to 0.182.0 ([#932](#932)).
@pietern pietern mentioned this pull request Jun 3, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jun 3, 2024
@pietern
Release v0.42.0 (#937)
094bca8 
* Ignore additional flaky test
([#930](#930)).
* Ignore DataPlane Services during generation
([#933](#933)).
* Update OpenAPI spec
([#934](#934)).

API Changes:

* Changed `List` method for
[a.AccountStorageCredentials](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#AccountStorageCredentialsAPI)
account-level service to return
[catalog.ListAccountStorageCredentialsResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ListAccountStorageCredentialsResponse).
* Added
[catalog.ListAccountStorageCredentialsResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ListAccountStorageCredentialsResponse).
* Added `TerminationCategory` field for
[jobs.ForEachTaskErrorMessageStats](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#ForEachTaskErrorMessageStats).
* Added
[oauth2.DataPlaneInfo](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#DataPlaneInfo).
* Removed `CreateDeployment` method for
[w.Apps](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#AppsAPI)
workspace-level service.
* Added `Deploy` method for
[w.Apps](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#AppsAPI)
workspace-level service.
* Added `Mode` field for
[serving.AppDeployment](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#AppDeployment).
* Added `Mode` field for
[serving.CreateAppDeploymentRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#CreateAppDeploymentRequest).
* Added `DataPlaneInfo` field for
[serving.ServingEndpointDetailed](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServingEndpointDetailed).
* Added
[serving.AppDeploymentMode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#AppDeploymentMode).
* Added
[serving.ModelDataPlaneInfo](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ModelDataPlaneInfo).

OpenAPI SHA: 37b925eba37dfb3d7e05b6ba2d458454ce62d3a0, Date: 2024-06-03

Dependency updates:

* Bump golang.org/x/mod from 0.16.0 to 0.17.0
([#879](#879)).
* Bump golang.org/x/oauth2 from 0.18.0 to 0.20.0
([#911](#911)).
* Bump golang.org/x/net from 0.24.0 to 0.25.0
([#912](#912)).
* Bump google.golang.org/api from 0.169.0 to 0.182.0
([#932](#932)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorcast-db hectorcast-db hectorcast-db approved these changes

@andrewnester andrewnester andrewnester approved these changes

@mgyucht mgyucht Awaiting requested review from mgyucht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pietern @codecov-commenter @andrewnester @hectorcast-db