[discuss] Don't generate shortcuts for list functions #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #935 +/- ##
========================================
- Coverage 7.13% 7.13% -0.01%
========================================
Files 281 281
Lines 64583 64596 +13
========================================
Hits 4609 4609
- Misses 59666 59677 +11
- Partials 308 310 +2 ☔ View full report in Codecov by Sentry. |
andrewnester
reviewed
Jun 3, 2024
| @@ -183,11 +183,19 @@ func (a *LibrariesAPI) Wait(ctx context.Context, wait Wait, | |||
| o(&i) | |||
| } | |||
| result, err := retries.Poll(ctx, i.Timeout, func() (*ClusterLibraryStatuses, *retries.Err) { | |||
| status, err := a.ClusterStatusByClusterId(ctx, wait.ClusterID) | |||
There was a problem hiding this comment.
Is this the only place where we explicitly use shortcut?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
ListByZZZfunctions don't use the same pagination as the main functions.By definition, the shortcut functions are generated only if there are required request parameters. Therefore, they should either return the same paginator, or not exist at all.
Tests
n/a