Noop minor refactoring of a apierr/error_override_test.go
#954
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR does a minor noop refactoring of
apierr/error_override_test.go
to better match the style of idiomatic table-tests. In particular, it:applyOverridesTestCase
struct which is replaced with an anonymous struct. There's nothing wrong with that struct per se but seeing it made me think at first that it was doing more than simply defining the table cases.name
field (was always "") and remove the subtests rather than giving them an arbitrary name (e.g. the index of the test).Alternatively, we could give meaningful names to the subtests and keep them. Though, what these names should be was not obvious to me.
Tests
The test coverage is the same as before this change.
make test
passingmake fmt
applied