Make ApiClient more pyodide friendly
#114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfx
added a commit
that referenced
this pull request
May 17, 2023
## Changes Embed `requests.Session` into ApiClient instead of extending it, so that `pyodide-http` [picks it up](https://github.com/koenvo/pyodide-http#supported-packages). ## Tests - [x] `make test` run locally - [ ] `make fmt` applied - [x] relevant integration tests applied
nfx
added a commit
that referenced
this pull request
May 17, 2023
# Version changelog ## 0.1.7 * Added an extensive set of examples ([#113](#113)). * Fixed broken `dbutils.fs.mount` and `dbutils.fs.updateMount` ([#119](#119)). * Ignore `.netrc` when sending unauthenticated requests for OAuth handshake ([#108](#108)). * Make ApiClient more `pyodide` friendly ([#114](#114)). * Persist token acquired through `external-browser` auth type ([#110](#110)). * Prototype for notebook-native auth ([#115](#115)). * Rename `RefreshableCredentials` to `SessionCredentials` ([#116](#116)). * Use shell for opening `az` cli on Windows ([#117](#117)).
Merged
nfx
added a commit
that referenced
this pull request
May 17, 2023
# Version changelog ## 0.1.7 * Added an extensive set of examples ([#113](#113)). * Fixed broken `dbutils.fs.mount` and `dbutils.fs.updateMount` ([#119](#119)). * Ignore `.netrc` when sending unauthenticated requests for OAuth handshake ([#108](#108)). * Make ApiClient more `pyodide` friendly ([#114](#114)). * Persist token acquired through `external-browser` auth type ([#110](#110)). * Prototype for notebook-native auth ([#115](#115)). * Rename `RefreshableCredentials` to `SessionCredentials` ([#116](#116)). * Use shell for opening `az` cli on Windows ([#117](#117)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Embed
requests.Sessioninto ApiClient instead of extending it, so thatpyodide-httppicks it up.Tests
make testrun locallymake fmtapplied