Jobs GoSDK schema migration #3532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardfeng-db
force-pushed
the
edwardfeng-db/go-sdk-jobs-migration-new
branch
2 times, most recently
from
99eef11
to
3dfdcd8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3532 +/- ##
==========================================
- Coverage 82.69% 82.67% -0.02%
==========================================
Files 183 184 +1
Lines 18826 18961 +135
==========================================
+ Hits 15568 15676 +108
- Misses 2341 2363 +22
- Partials 917 922 +5
|
edwardfeng-db
force-pushed
the
edwardfeng-db/go-sdk-jobs-migration-new
branch
from
03ad8ae
to
42cfdd3
Compare
edwardfeng-db
commented
May 3, 2024
edwardfeng-db
commented
May 3, 2024
edwardfeng-db
requested review from
mgyucht and
tanmay-db
and removed request for
hectorcast-db
mgyucht
reviewed
May 3, 2024
edwardfeng-db
force-pushed
the
edwardfeng-db/go-sdk-jobs-migration-new
branch
from
0c00f75
to
b71970b
Compare
|
Triggered integration tests and confirmed that no failure is related to this change |
mgyucht
reviewed
May 7, 2024
mgyucht
approved these changes
May 8, 2024
tanmay-db
added a commit
that referenced
this pull request
May 13, 2024
### New Features and Improvements * fix ([#3542](#3542)). * Update data_aws_crossaccount_policy to format resource string with account and region ([#3544](#3544)). * Robust retries for workspace get-status ([#3550](#3550)). * Fix error message typo in mounts.go ([#3552](#3552)). * State the options for run_if ([#3548](#3548)). * Exporter: don't emit all UC objects when handling dependencies ([#3556](#3556)). * Added state upgrader to remove `max_clusters_per_user` and ebs volume attributes set to zero ([#3551](#3551)). * Exporter: track removed objects during the `Emit` phase ([#3554](#3554)). * Jobs GoSDK schema migration ([#3532](#3532)). * Exporter: optimize generation of `databricks_group_member` resource ([#3559](#3559)). ### Documentation Changes ### Exporter ### Internal Changes
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 14, 2024
* Release v1.43.0 ### New Features and Improvements * fix ([#3542](#3542)). * Update data_aws_crossaccount_policy to format resource string with account and region ([#3544](#3544)). * Robust retries for workspace get-status ([#3550](#3550)). * Fix error message typo in mounts.go ([#3552](#3552)). * State the options for run_if ([#3548](#3548)). * Exporter: don't emit all UC objects when handling dependencies ([#3556](#3556)). * Added state upgrader to remove `max_clusters_per_user` and ebs volume attributes set to zero ([#3551](#3551)). * Exporter: track removed objects during the `Emit` phase ([#3554](#3554)). * Jobs GoSDK schema migration ([#3532](#3532)). * Exporter: optimize generation of `databricks_group_member` resource ([#3559](#3559)). ### Documentation Changes ### Exporter ### Internal Changes * - * - * -
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
typeToSchemacheck and reuse information for registered resources in theresourceProviderRegistryLibraryout of the registry because the only customization is not needed in other resourcesCustomizeSchemafunction that takes in all of the existing customizationsDataToStructPointerandStructToDatafunction callsresource_job_testCustomizeSchemaResourceSpecificfunction so that customizations don't always have to be shared for registry referencesTests
make testrun locallydocs/folderinternal/acceptance