-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error message typo in mounts.go #3552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to change error message in the tests as well - to
failed to get mounting cluster: nope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3552 +/- ##
=======================================
Coverage 82.66% 82.66%
=======================================
Files 184 184
Lines 18857 18857
=======================================
Hits 15588 15588
Misses 2351 2351
Partials 918 918
|
### New Features and Improvements * fix ([#3542](#3542)). * Update data_aws_crossaccount_policy to format resource string with account and region ([#3544](#3544)). * Robust retries for workspace get-status ([#3550](#3550)). * Fix error message typo in mounts.go ([#3552](#3552)). * State the options for run_if ([#3548](#3548)). * Exporter: don't emit all UC objects when handling dependencies ([#3556](#3556)). * Added state upgrader to remove `max_clusters_per_user` and ebs volume attributes set to zero ([#3551](#3551)). * Exporter: track removed objects during the `Emit` phase ([#3554](#3554)). * Jobs GoSDK schema migration ([#3532](#3532)). * Exporter: optimize generation of `databricks_group_member` resource ([#3559](#3559)). ### Documentation Changes ### Exporter ### Internal Changes
* Release v1.43.0 ### New Features and Improvements * fix ([#3542](#3542)). * Update data_aws_crossaccount_policy to format resource string with account and region ([#3544](#3544)). * Robust retries for workspace get-status ([#3550](#3550)). * Fix error message typo in mounts.go ([#3552](#3552)). * State the options for run_if ([#3548](#3548)). * Exporter: don't emit all UC objects when handling dependencies ([#3556](#3556)). * Added state upgrader to remove `max_clusters_per_user` and ebs volume attributes set to zero ([#3551](#3551)). * Exporter: track removed objects during the `Emit` phase ([#3554](#3554)). * Jobs GoSDK schema migration ([#3532](#3532)). * Exporter: optimize generation of `databricks_group_member` resource ([#3559](#3559)). ### Documentation Changes ### Exporter ### Internal Changes * - * - * -
Changes
Tests
make test
run locallydocs/
folderinternal/acceptance