Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize integration tests #3542

Merged
merged 1 commit into from
May 3, 2024
Merged

Stabilize integration tests #3542

merged 1 commit into from
May 3, 2024

Conversation

mgyucht
Copy link
Contributor

@mgyucht mgyucht commented May 3, 2024

Changes

Recently, I observed a couple of issues with integration tests:

  • TestMwsAccGroupDataSplitMembers and TestAccServicePrincipalResourceOnAws failed due to the API not responding with the correct information after update. I've added these to flaky tests.
  • TestMwsAccAccountServicePrincipalRuleSetsFullLifeCycle failed flakily because we use no ETag, which as a result returns a stale version of the setting. I changed the check to use the ETag stored in TF state, which should ensure that the latest version of the setting is always returned.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@mgyucht mgyucht requested review from a team as code owners May 3, 2024 13:20
@mgyucht mgyucht requested review from tanmay-db and removed request for a team May 3, 2024 13:20
@mgyucht mgyucht added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit ee1e4b5 May 3, 2024
5 checks passed
@mgyucht mgyucht deleted the some-integration-test-fixes branch May 3, 2024 13:38
tanmay-db added a commit that referenced this pull request May 13, 2024
### New Features and Improvements
* fix ([#3542](#3542)).
* Update data_aws_crossaccount_policy to format resource string with account and region ([#3544](#3544)).
* Robust retries for workspace get-status ([#3550](#3550)).
* Fix error message typo in mounts.go ([#3552](#3552)).
* State the options for run_if ([#3548](#3548)).
* Exporter: don't emit all UC objects when handling dependencies ([#3556](#3556)).
* Added state upgrader to remove `max_clusters_per_user` and ebs volume attributes set to zero ([#3551](#3551)).
* Exporter: track removed objects during the `Emit` phase ([#3554](#3554)).
* Jobs GoSDK schema migration ([#3532](#3532)).
* Exporter: optimize generation of `databricks_group_member` resource ([#3559](#3559)).

### Documentation Changes

### Exporter

### Internal Changes
@tanmay-db tanmay-db mentioned this pull request May 13, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 14, 2024
* Release v1.43.0

### New Features and Improvements
* fix ([#3542](#3542)).
* Update data_aws_crossaccount_policy to format resource string with account and region ([#3544](#3544)).
* Robust retries for workspace get-status ([#3550](#3550)).
* Fix error message typo in mounts.go ([#3552](#3552)).
* State the options for run_if ([#3548](#3548)).
* Exporter: don't emit all UC objects when handling dependencies ([#3556](#3556)).
* Added state upgrader to remove `max_clusters_per_user` and ebs volume attributes set to zero ([#3551](#3551)).
* Exporter: track removed objects during the `Emit` phase ([#3554](#3554)).
* Jobs GoSDK schema migration ([#3532](#3532)).
* Exporter: optimize generation of `databricks_group_member` resource ([#3559](#3559)).

### Documentation Changes

### Exporter

### Internal Changes

* -

* -

* -
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants