Robust retries for workspace get-status #3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexott
approved these changes
May 6, 2024
hectorcast-db
approved these changes
May 7, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3550 +/- ##
==========================================
- Coverage 82.70% 82.66% -0.05%
==========================================
Files 183 184 +1
Lines 18829 18857 +28
==========================================
+ Hits 15573 15588 +15
- Misses 2340 2351 +11
- Partials 916 918 +2
|
tanmay-db
added a commit
that referenced
this pull request
May 13, 2024
### New Features and Improvements * fix ([#3542](#3542)). * Update data_aws_crossaccount_policy to format resource string with account and region ([#3544](#3544)). * Robust retries for workspace get-status ([#3550](#3550)). * Fix error message typo in mounts.go ([#3552](#3552)). * State the options for run_if ([#3548](#3548)). * Exporter: don't emit all UC objects when handling dependencies ([#3556](#3556)). * Added state upgrader to remove `max_clusters_per_user` and ebs volume attributes set to zero ([#3551](#3551)). * Exporter: track removed objects during the `Emit` phase ([#3554](#3554)). * Jobs GoSDK schema migration ([#3532](#3532)). * Exporter: optimize generation of `databricks_group_member` resource ([#3559](#3559)). ### Documentation Changes ### Exporter ### Internal Changes
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 14, 2024
* Release v1.43.0 ### New Features and Improvements * fix ([#3542](#3542)). * Update data_aws_crossaccount_policy to format resource string with account and region ([#3544](#3544)). * Robust retries for workspace get-status ([#3550](#3550)). * Fix error message typo in mounts.go ([#3552](#3552)). * State the options for run_if ([#3548](#3548)). * Exporter: don't emit all UC objects when handling dependencies ([#3556](#3556)). * Added state upgrader to remove `max_clusters_per_user` and ebs volume attributes set to zero ([#3551](#3551)). * Exporter: track removed objects during the `Emit` phase ([#3554](#3554)). * Jobs GoSDK schema migration ([#3532](#3532)). * Exporter: optimize generation of `databricks_group_member` resource ([#3559](#3559)). ### Documentation Changes ### Exporter ### Internal Changes * - * - * -
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
To reduce flakiness of Terraform when calling Workspace Get Status, I've added retries around
GetStatusByPathfor all usages of this API in the Terraform provider (aside from the exporter, which depends on a field that isn't yet exposed in the SDK). This should help increase stability of fetching the status of notebooks and directories in the provider.This change introduces a utility to retry on timeout for this common use case. We may want to add this to the Go SDK if we feel it is generally useful as a retry option (e.g.
retries.OnRequestTimeout).Longer term, we should handle these retries for idempotent APIs directly in the SDK.
Tests
Unit tests verify that this retries on timeouts but otherwise doesn't retry.
make testrun locallydocs/folderinternal/acceptance