Find project root when run from a wheel (logger module) #43
Conversation
sundarshankar89
temporarily deployed
to
runtime
GitHub Actions
Inactive
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
- Coverage 77.08% 76.80% -0.28%
==========================================
Files 13 13
Lines 1270 1272 +2
Branches 230 231 +1
==========================================
- Hits 979 977 -2
- Misses 201 204 +3
- Partials 90 91 +1 ☔ View full report in Codecov by Sentry. |
| for leaf in ("pyproject.toml", "setup.py"): | ||
| root = find_dir_with_leaf(this_path, leaf) | ||
| if root is not None: | ||
| return root | ||
| # Wheel installation is under site-packages hence return the parent of site-packages | ||
| if "site-packages" in __file: | ||
| return Path(__file.split("site-packages")[0] + "site-packages/") |
There was a problem hiding this comment.
And what if there are many modules with "about.py"?
There was a problem hiding this comment.
This is presenting a workaround since we don't do anything with PROJECT_ROOT variables, to answer your question it doesn't matter, the path is going to be set from Python env location where wheel file is installed.
Ideally just rewriting the get_logger to get module name directly would make sense.
There was a problem hiding this comment.
Please take a look at the usages of this function in the library.
As for remoph - logging.get_logger(name) might be enough. The utility of blueprint is to help only when name is main
|
use |
No description provided.