Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Support library installs with a path that contains spaces #1859

Closed
1 task done
JCZuurmond opened this issue Jun 7, 2024 · 0 comments · Fixed by #2330
Closed
1 task done

[BUG]: Support library installs with a path that contains spaces #1859

JCZuurmond opened this issue Jun 7, 2024 · 0 comments · Fixed by #2330
Assignees
@ericvergnaud

Comments

@JCZuurmond
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Problem statement

Support library install with a path that contains spaces

Proposed Solution

In #1853 quotes around the install arguments are introduced, however, the failing integration test in test_libraries shows that does not work. Investigate why.

An alternative is to use the InstallCommand from pip._internal.commands (see cells.py)

Additional Context

See failing test introduced by #1853.
@JCZuurmond JCZuurmond added enhancement New feature or request needs-triage labels Jun 7, 2024
@JCZuurmond JCZuurmond added this to UCX Jun 7, 2024
@github-project-automation github-project-automation bot moved this to Triage in UCX Jun 7, 2024
@nfx nfx added tech debt chores and design flaws and removed enhancement New feature or request needs-triage labels Jun 7, 2024
@nfx nfx moved this from Triage to Quarter Backlog in UCX Jun 7, 2024
@JCZuurmond JCZuurmond mentioned this issue Jun 11, 2024
Merged
7 tasks
@JCZuurmond JCZuurmond changed the title [TECH DEBT]: Support library installs with a path that contains spaces [BUG]: Support library installs with a path that contains spaces Jul 17, 2024
@JCZuurmond JCZuurmond added bug and removed tech debt chores and design flaws labels Jul 17, 2024
@ericvergnaud ericvergnaud mentioned this issue Jul 31, 2024
Merged
1 task
@ericvergnaud ericvergnaud self-assigned this Jul 31, 2024
@nfx nfx closed this as completed in #2330 Aug 2, 2024
@nfx nfx closed this as completed in 4f6704c Aug 2, 2024
@github-project-automation github-project-automation bot moved this from Quarter Backlog to Archive in UCX Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericvergnaud ericvergnaud

Labels
None yet
Projects
UCX
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support spaces in run cmd args databrickslabs/ucx
3 participants
@nfx @ericvergnaud @JCZuurmond