Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad support for aliases inside join statements #29

Closed
filipsch opened this issue Aug 13, 2018 · 4 comments
Closed

Bad support for aliases inside join statements #29

filipsch opened this issue Aug 13, 2018 · 4 comments
Labels

Comments

@filipsch
Copy link
Contributor

Look at this example. The alias of the inner join is parsed properly, but the tree representation turns it into an Unshaped node while it should be an AliasExpr.

@machow The plsql.g4 file doesn't need changing for this, I think, but the ast.py file does. Is this correct? Do you have time to pair on this at some point?

@filipsch filipsch added the bug label Aug 13, 2018
@filipsch filipsch self-assigned this Aug 13, 2018
@machow
Copy link
Contributor

machow commented Aug 14, 2018

@filipsch I'm probably doing something wrong but I can't see the unshaped node. Happy to pair whenever is useful!

image

@filipsch
Copy link
Contributor Author

@machow Sorry, had a wrong example in there. This example would show it:

SELECT a FROM co AS c INNER JOIN ec AS e ON c.code = e.code

image

@machow
Copy link
Contributor

machow commented Aug 14, 2018

Ah, I think that's the alias piece I mention in issue #30

  1. implement some AST structure for table aliases (see this query)

@filipsch filipsch removed their assignment Sep 13, 2018
@hermansje
Copy link
Member

This is what it looks like now:
Screenshot 2019-03-25 at 23 56 04

ast-viewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants