Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added alternative first entry for SRA accession SRP064605 #120

Merged
merged 3 commits into from
Sep 26, 2019

Conversation

laninsky
Copy link
Contributor

REL4541B was not the first entry in the SRA Run Selector Table when I viewed the link (it was actually the last), so also added REL762B (which was the first run). Think it will confuse folks if the run they are told to look for isn't there.

REL4541B was not the first entry in the SRA Run Selector Table when I viewed the link (it was actually the last), so also added [REL762B](https://trace.ncbi.nlm.nih.gov/Traces/sra/?run=SRR2584403) (which was the first run). Think it will confuse folks if the run they are told to look for isn't there.
@hoytpr
Copy link
Contributor

hoytpr commented Sep 24, 2019

Hi @laninsky and thanks very much for catching this! It looks like this happened because the entire SRA is moved to "the cloud". This was bound to happen anyway, because more data will be added as the experiment continues!

Rather than look for "REL4541B" or "REL762B", maybe we should simply say "the first" Run Number as a longer term solution otherwise this will keep happening. Could you make that change to your PR? Then we could incorporate it. I appreciate your help with this, and we should leave this open for comments.

Comments from @raynamharris , or @mkuzak welcome (Other maintainers names may have changed?)

Modified to just clicking on the first run in response to pull request comment
added a little more context on *what* table we are referring to
@laninsky
Copy link
Contributor Author

Cool, all done @hoytpr! @rltillett 's solution could be a good solution too

@hoytpr
Copy link
Contributor

hoytpr commented Sep 25, 2019

Hi @laninsky , and thanks. After going through the process and performing the search as @rltillett suggests in #121 , I like the search idea. It works and maintains the consistency of the lesson for downstream use. Could you and @rltillett make this happen? It would be a nice contribution!

Peter

@laninsky
Copy link
Contributor Author

Hi Peter - definitely keen to help out on this but probably won't be for a little while due to my work commitments. In the meantime, might we make this change just to reduce confusion in the short-term?

@hoytpr hoytpr merged commit 00a86c4 into datacarpentry:gh-pages Sep 26, 2019
@hoytpr hoytpr mentioned this pull request Apr 28, 2020
zkamvar pushed a commit that referenced this pull request May 2, 2023
Added alternative first entry for SRA accession SRP064605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants