Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes and typos #330

Merged
merged 6 commits into from
Apr 11, 2023
Merged

Conversation

martinosorb
Copy link
Contributor

@martinosorb martinosorb commented Feb 21, 2023

A few minor changes:

  • In the index's introductory explanation there were at least a couple of typos. Fixes A typo in the introduction part #326.
  • The same introduction had some unclear 'etc.' and less polished language that I edited.
  • Braces are not usually called "squiggle braces". I Googled this expression and it's essentially only found in that Carpentries lesson. I edited to "curly brackets", which is the common name of braces in British English.
  • The wording "standard QWERTY keyboard" is incorrect and also not inclusive. There is no standard QWERTY. I edited to clarify, although it's impossible to give a comprehensive instruction on where the | key is on all keyboard layouts.
  • I edited an exercise adding a line to the solution rather than as a comment after the exercise.
  • Typos in episode 1, fixes Typos in Introducing the Shell lesson, How to access the shell section  #329

Copy link
Member

@tobyhodges tobyhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm processing outstanding pull requests on this repository, in preparation for transition to the new lesson infrastructure. Thank you for contributing these improvements, @martinosorb.

I am ambivalent about the addition of "software" to the list on line 9 of index.md, but otherwise I think the changes are clearly for the better.

However, some conflicts have been introduced in the time since the PR was opened. If you can resolve these before the infrastructure transition takes place at the end of the month, I will be delighted to merge.

@martinosorb
Copy link
Contributor Author

The "software" part was meant to say that programs also have command line interfaces, rather than being "apps" with a GUI and that kind of stuff. How about "commands" or "programs"?

@tobyhodges
Copy link
Member

Oh ok, I think I understand better now - I think this was a misunderstanding on my part, rather than something that needs to be improved in your wording.

Thanks for resolving the conflicts - I am going to merge the PR now.

@tobyhodges tobyhodges merged commit 4cf803a into datacarpentry:gh-pages Apr 11, 2023
@martinosorb
Copy link
Contributor Author

Thank you!

zkamvar pushed a commit that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typos in Introducing the Shell lesson, How to access the shell section A typo in the introduction part
2 participants