Make unit tests pass under Python 3. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the issues were related to text encoding (byte vs utf-8), and XML attributes ordering. These were fixed by modifying the tests to work with both Python 3, and Python 2.7. One interesting library issue identified was the ordering of elements in the XML document that is produced from PyACI. As it was internally using dictionary to store the list of children, the resulting element order was at the mercy of the order of dictionary keys. To make this work correctly, modified the library to use OrderedDict.
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=========================================
+ Coverage 60.02% 60.1% +0.08%
=========================================
Files 8 8
Lines 918 920 +2
=========================================
+ Hits 551 553 +2
Misses 367 367
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the issues were related to text encoding (byte vs utf-8), and XML
attributes ordering. These were fixed by modifying the tests to work with both
Python 3, and Python 2.7.
One interesting library issue identified was the ordering of elements in the XML
document that is produced from PyACI. As it was internally using dictionary to
store the list of children, the resulting element order was at the mercy of the
order of dictionary keys. To make this work correctly, modified the library to
use OrderedDict.