Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form field masking #783

Closed
wants to merge 2 commits into from
Closed

Form field masking #783

wants to merge 2 commits into from

Conversation

svogt0511
Copy link
Contributor

@svogt0511 svogt0511 commented Sep 8, 2023

Purpose

Allow the user to show/hide password fields in the update password forms.

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@svogt0511 svogt0511 self-assigned this Sep 8, 2023
@cypress
Copy link

cypress bot commented Sep 8, 2023

1 flaky test on run #915 ↗︎

0 87 7 0 Flakiness 1

Details:

Merge 54c9234 into d9e9741...
Project: bracco Commit: 115303b66b ℹ️
Status: Passed Duration: 04:47 💡
Started: Sep 8, 2023 2:28 AM Ended: Sep 8, 2023 2:32 AM
Flakiness  cypress/e2e/client_admin/doi.test.ts • 1 flaky test • Tests

View Output Video

Test Artifacts
ACCEPTANCE: CLIENT_ADMIN | DOIS > is creating a doi - FILE UPLOAD Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@svogt0511 svogt0511 linked an issue Sep 8, 2023 that may be closed by this pull request
@svogt0511 svogt0511 removed a link to an issue Sep 8, 2023
@svogt0511 svogt0511 linked an issue Sep 8, 2023 that may be closed by this pull request
@svogt0511 svogt0511 closed this Apr 4, 2024
@svogt0511
Copy link
Contributor Author

This is fixed in the Ember v3.28 update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password form fields need buttons for masking/revealing the field contents.
1 participant