Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strip out orcid url scheme for people search #1014

Merged
merged 6 commits into from
Oct 3, 2023
Merged

strip out orcid url scheme for people search #1014

merged 6 commits into from
Oct 3, 2023

Conversation

wendelfabianchinsamy
Copy link
Contributor

@wendelfabianchinsamy wendelfabianchinsamy commented Sep 28, 2023 •
edited
Loading

Purpose

closes: datacite/datacite#1786

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@wendelfabianchinsamy wendelfabianchinsamy self-assigned this Sep 28, 2023
@wendelfabianchinsamy wendelfabianchinsamy requested a review from a team September 29, 2023 07:12
kaysiz
kaysiz approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@kaysiz kaysiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@wendelfabianchinsamy wendelfabianchinsamy merged commit ee4b505 into master Oct 3, 2023
11 checks passed
@wendelfabianchinsamy wendelfabianchinsamy deleted the strip-orcid-url-scheme-out-on-person-search branch October 3, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardhallett richardhallett richardhallett approved these changes

@kaysiz kaysiz kaysiz approved these changes

Assignees

@wendelfabianchinsamy wendelfabianchinsamy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search for full ORCID iD in Commons generates error
3 participants
@wendelfabianchinsamy @richardhallett @kaysiz