Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fair Workflows Feature 5 #1028

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Fair Workflows Feature 5 #1028

merged 2 commits into from
Oct 24, 2023

Conversation

bklaing2
Copy link
Member

Purpose

Added quick fix for returning Project as resourceType, which should be removed once Project officially becomes a resourceType in the Schema

datacite/datacite#1929

Approach

Checks if resourceType == "Project" AND (resourceTypeGeneral == "Text" OR resourceTypeGeneral == "Other"

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@bklaing2 bklaing2 requested a review from jrhoads October 23, 2023 11:55
@bklaing2 bklaing2 self-assigned this Oct 23, 2023
Copy link
Contributor

@jrhoads jrhoads left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bklaing2 bklaing2 merged commit b866d60 into master Oct 24, 2023
11 checks passed
@bklaing2 bklaing2 deleted the fair-work-feature-5 branch October 24, 2023 11:34
@sentry-io
Copy link

sentry-io bot commented Oct 24, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ **NoMethodError: undefined method []' for nil:NilClass** app/models/doi.rb in handleResourceType` View Issue
  • ‼️ **NoMethodError: undefined method []' for nil:NilClass** app/models/doi.rb in handleResourceType` View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants