Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix N+1 - as_indexed_json - DOI #1150

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Fix N+1 - as_indexed_json - DOI #1150

merged 4 commits into from
Apr 3, 2024

Conversation

kaysiz
Copy link
Contributor

@kaysiz kaysiz commented Mar 6, 2024 •
edited
Loading

Purpose

Fix N+1 on dois

closes: #1151

Approach

preload all required associations.

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@kaysiz kaysiz self-assigned this Mar 6, 2024
@kaysiz kaysiz marked this pull request as ready for review March 7, 2024 07:46
@kaysiz kaysiz requested a review from a team March 7, 2024 07:47
jrhoads
jrhoads approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@jrhoads jrhoads left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to keep an eye on memory consumption.
As this will be increased quite a bit by pre-fetching all of these for each batch.
I still think its a good idea but it is something to monitor.

@kaysiz kaysiz changed the title Fix N+1 - as_indexed_json Fix N+1 - as_indexed_json - DOI Mar 11, 2024
kaysiz and others added 2 commits March 20, 2024 09:56
@kaysiz
Fix big multiple query inside import by ids
8377e29 
Co-authored-by: Ashwini <ashwini.sukale@datacite.org>
Co-authored-by: Kudakwashe <kuda.siziva@datacite.org>
@ashwinisukale @kaysiz
Add author
8ff5a09
@kaysiz kaysiz requested review from jrhoads and a team March 20, 2024 08:04
@ashwinisukale ashwinisukale self-assigned this Mar 20, 2024
@kaysiz kaysiz merged commit 65a1ab7 into master Apr 3, 2024
13 checks passed
@kaysiz kaysiz deleted the performance/fix-as-indexed-json-queries branch April 3, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhoads jrhoads jrhoads approved these changes

Assignees

@ashwinisukale ashwinisukale

@kaysiz kaysiz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix N+1 - as_indexed_json
3 participants
@kaysiz @jrhoads @ashwinisukale