Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ids filter #999

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Fix ids filter #999

merged 2 commits into from
Aug 21, 2023

Conversation

jrhoads
Copy link
Contributor

@jrhoads jrhoads commented Aug 18, 2023

Purpose

Fix an issue with the ids filter.

closes: #998

Approach

Re-adds the check to convert a single string into an array, by splitting on commas.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@jrhoads jrhoads merged commit 655944a into master Aug 21, 2023
10 checks passed
@jrhoads jrhoads deleted the fix-ids-filter branch August 21, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoMethodError: undefined method `map' for "999":String
2 participants