Suggestion for Issue 401 #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g changes to test pre-commit
…orrect flake8 errors, make error message more clear
|
I'm 👍 on this. How do you feel about it @npdoty ? I feel like this sort of change should have your buy in! |
|
I have included isort into this PR, as it is another handy pre-commit routine that automates the sorting of package imports to make the order consistent across files. Also, after you have reviewed the changes due to the pre-commit routine in mailman.py don't accept this PR straight away. Let's apply the routine on all files first. |
…imports to add consistency
|
Since @npdoty is in dissertation isolation mode, I will unilaterally approve this PR. Thanks for the contribution @Christovis |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add a pre-commit routine as outlined here. The effect will be, that whenever we execute
git commit -m ...black and flake8 will check and format the code automatically.The configuration is such that the black formatting keeps the PEP8 line-length but there are some other very small differences (I don't know the details). If black really causes headaches, it can always be forced to be more faithful to PEP8.
I tested the pre-commit routine on ./bigbang/mailman.py. Thus there changes in that file are mainly because of black and because flak8 raised some warnings and errors.
New files:
./pre-commit-config.yaml
./pyproject.toml
./.flake8