Prepare 1.18.0 ( and small fix in update_changelog ) #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSerrania
reviewed
Jun 27, 2023
CHANGELOG.rst
Outdated
| ================ | ||
|
|
||
| - AP-2106 Add new GPG keys for APT and RPM repositories signature rotation (#44) |
There was a problem hiding this comment.
I'd remove the AP-2106, it's useful for internal tracking of PRs, but doesn't need to end up in the changelog.
CHANGELOG.rst
Outdated
| ================ | ||
|
|
||
| - AP-2106 Add new GPG keys for APT and RPM repositories signature rotation (#44) | ||
| - Restore usage of underscores in options as it would require change at several places and would probably bring confusion (#52) | ||
| - SLES 11 install script support (#51) |
There was a problem hiding this comment.
Technically, SLES 11 was supported before, but we broke support in an earlier version, so I'd change this to:
Suggested change
| - SLES 11 install script support (#51) | |
| - Fix install script on SLES 11 (#51, #52) |
CHANGELOG.rst
Outdated
| ================ | ||
|
|
||
| - AP-2106 Add new GPG keys for APT and RPM repositories signature rotation (#44) | ||
| - Restore usage of underscores in options as it would require change at several places and would probably bring confusion (#52) |
There was a problem hiding this comment.
This is a fix to another change in the same version (#51), and therefore doesn't need to be shown in the changelog.
KSerrania
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.