feat: Add install script for Vector #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouquette
reviewed
Oct 6, 2023
|
|
||
| $sudo_cmd sh -c "DEBIAN_FRONTEND=noninteractive apt-get install -y apt-transport-https curl gnupg 2>$VEC_APT_INSTALL_ERROR_MSG || apt_exit_code=$?" | ||
|
|
||
| if grep "Could not get lock" $VEC_APT_INSTALL_ERROR_MSG; then |
There was a problem hiding this comment.
I realize this is not at all related to your PR, but how does this check behaves with i18n?
There was a problem hiding this comment.
😓 probably poorly, but it doesn't appear to have come up for the "upstream" scripts yet? Might be worth opening an issue to track though.
There was a problem hiding this comment.
Oh yeah this is definitely a question for the upstream version, but I didn't thought of it at the time 😬
There was a problem hiding this comment.
https://datadoghq.atlassian.net/browse/APL-2224 created for that purpose
chouquette
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened as an alternative to vectordotdev/vector#18777
This struck me as a better location to maintain the script as AP is likely to be responsible for it as it is for the Agent and OPW scripts. Additionally since the scripts are so
copiedrelated co-locating them seems sensible.Original PR