[e2e] add e2e tests #98
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouetz
reviewed
Oct 9, 2023
test/e2e/agentplatform.go
Outdated
| } | ||
|
|
||
| const ( | ||
| scriptURL = "https://dd-agent.s3.amazonaws.com/custom" |
There was a problem hiding this comment.
It means we might state somewhere we need to push the install_scripts to be tested in the custom folder prior launching the tests, correct?
There was a problem hiding this comment.
True, will change it in a follow up PR to take a param or an env var
There was a problem hiding this comment.
Actually will move it in this PR to a flag
chouetz
approved these changes
Oct 9, 2023
Meant to run locally, for now
pducolin
force-pushed
the
pducolin/e2e-tests
branch
from
3b8dc0e to
3efb18f
Compare
|
I'm closing this PR and opening a new, smaller one. Will add up based on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to run locally, for now
They implement in go https://github.com/DataDog/experimental/blob/main/teams/agent-platform/package-scripts-test/install_test.sh