-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
High CPU usage #119
Comments
Hi! @joeldodge79, sorry to hear that! Can you provide a little bit more detail about your environment, e.g. OS, php version, bits (I assume 64)? I will try to reproduce the issue in a docker + centos (I guessed from .rpm) environment with your code and will post the outcome here. Also bringing @pawelchcki in the loop (our C-extension master) |
Ok I did a very quick test and things looks good as I do not see any CPU anomaly, so must be something else. ============================================================================== I used the following
Build:
Run through
index.php
|
Sorry, I closed it by mistake |
thanks for the quick reply! Here's some initial env info, I'll work on debugging this some more today: php-fpm 7.1.23 running via nginx 1.12.1 on amazon linux 2018.3 :
|
FYI I've discovered some memory leaks in the extension which might be at least tangentially related to this issue. Working on a patch. :) |
I'm still trying to reproduce this issue in a way that's easy to share. I've narrowed it down to enabling the PDO integration: commenting out |
Hey @joeldodge79, just out of curiosity, were you able to re-enable the PDO integration and to have it work properly? |
Hey @joeldodge79, I am closing this issue as it refers to a relatively old version and it had no interactions from a while. Feel free to re-open it if you still experience the issue. We are very interested in addressing any memory issue that may exist. |
Hey, We're using Magento 1 and the site crashes when enabling the PDOIntegration, and also other integrations such as ElasticSearchIntegration and CurlIntegration Simply adding the following code causes our site to crash using dd-trace-php 0.9.1
If I create a very simple Magento 1 shell script, and enable the PDOIntegration, that shell script will work, e.g:
To me, the behaviour seems like memory leaks, because it crashes as soon as we use it on a full Magento page load. |
Hi @danelowe thanks for the detailed feedback. We may need a few more info in order to track down the bug. Which PHP and OS versions are using?
So if my understanding of the problem is correct, when you add that code you do not use our other integrations at all. So, for example, you don't call Magento is in our road map, but if you can point us to a simple test app that replicates the issue with instructions about how to run it we would will be happy to try a quick debug session! Thanks! |
Hi @labbati, This is with php7.2 on Ubuntu 14.04. I will look into getting 0.10.0 in the next couple of days. I was just waiting for the .deb release first. You understood correctly. It crashes with that code added, and no other code to load any integrations. If 0.10.0 doesn't work, I will try to get a docker compose file ready with a Magento 1 demo. |
@labbati I spent the day creating a test app running in docker with test data and a fresh install of Magento. Unfortunately I cannot replicate the issue in this docker container. I can so far only replicate in our production server (with numerous services installed directly in Ubuntu). Is there any way you can think of to debug further in this environment? |
Hi, thanks for taking time to look into this 🙇
.deb is loaded, it was my mistake during first hours from the upload.
Typically a good starting point is to match |
Hi @danelowe, since our last message we introduced a few versions which, among other things, fixed a number of memory leaks we have found in our integration. If you could give it a chance and test in your magento app it would be great! Based on the time of your latest comment you MAY already be on 0.10+, in that case the update would be smooth. If you are on a <0.10 please look into the migration guide. Thanks 😃 |
Hi @labbati, I installed 0.13.1 php extension on our server via the .deb package (left the composer dependency at 0.10.0). The same code seems to cause our site to crash
I wondered if there is some way this code leads to a non-terminating loop, but I couldn't replicate it in another environment, and can't think of anything that would cause it in Magento's code base. At the moment, I've just manually instrumented Magento's PDO adapter. |
We're using Magento 1 and I decided to just throw this code into our index.php file as a first stab at seeing some data:
we got data in the datadog APM UI ... but the webserver slammed to 100% cpu and stopped responding. any suggestions?
The text was updated successfully, but these errors were encountered: