Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobufjs should be a regular dependency (not devDependency) #26

Open
jfirebaugh opened this issue Aug 9, 2023 · 0 comments
Open

protobufjs should be a regular dependency (not devDependency) #26

jfirebaugh opened this issue Aug 9, 2023 · 0 comments

Comments

@jfirebaugh
Copy link

protobufjs is in devDependencies:

sketches-js/package.json

Line 44 in 222854e

"protobufjs": "^6.11.3",

But it's required here:

sketches-js/src/ddsketch/proto/compiled.js

Line 4 in 222854e

var $protobuf = require("protobufjs/minimal");

So it should be a regular dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jfirebaugh