Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require nose as dependency #82

Closed
wants to merge 1 commit into from
Closed

Require nose as dependency #82

wants to merge 1 commit into from

Conversation

hukkin
Copy link

@hukkin hukkin commented May 7, 2020 •
edited
Loading

The latest release (1.4.0) does a from nose.tools import nottest import but does not list nose as a dependency of ddt.

This PR adds nose as a dependency in setup.py

@hukkin
Copy link
Author

hukkin commented May 7, 2020

@wswld could you have a look?

@hukkin
Copy link
Author

hukkin commented May 7, 2020

Removing nose usage and dependency altogether is probably the best option though (as done @mtreinish here it seems #84 ).

@wswld wswld mentioned this pull request May 12, 2020
Merged
@wswld
Copy link
Contributor

wswld commented May 15, 2020

Addressed the issue in #86, will close this one.

@wswld wswld closed this May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hukkin @wswld @hukkinj1