Gmguarino/remove recofish proxy #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gmguarino
commented
Oct 8, 2023
gmguarino
commented
- Making sure the /opt/d4g-proxy/nginx-conf/ does not exist before the configuration files are created
- Fixed paths in playbook
- Removed Recofish project proxy
pagbrl
requested changes
Oct 9, 2023
| @@ -26,15 +33,6 @@ | |||
| notify: | |||
| - "nginx config updated" | |||
|
|
|||
| - name: Create services configurations | |||
There was a problem hiding this comment.
We should keep this block for future services, I think we could just add a "dummy" service for that that proxies to the machine IP
|
@pagbrl should be good. Do you want to check? |
|
Looks good, I'll add a dummy default nginx backend in a few minutes and then we can merge this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.