Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation not working #79

Open
MichalMed opened this issue Nov 9, 2020 · 4 comments · Fixed by #80
Open

Validation not working #79

MichalMed opened this issue Nov 9, 2020 · 4 comments · Fixed by #80
Assignees
@psiotwo
Labels
bug Something isn't working

Comments

@MichalMed
Copy link
Contributor

When I run the validation in eSbírka WS, nothing happens, the in progress circle just keep rotating.
@bindeali
Copy link
Collaborator

bindeali commented Nov 9, 2020

@psiotwo This might be a problem with the server. Validating the ontoGrapher test workspace returns results just fine after about 5-10 seconds, eSbírka fails after about two minutes with a 502. Tested with ontoGrapher and cURL.

Request URL: https://kbss.felk.cvut.cz/sgov-server/workspaces/instance-1703508316/validate?namespace=https://slovn%C3%ADk.gov.cz/datov%C3%BD/pracovn%C3%AD-prostor/pojem/metadatov%C3%BD-kontext/
Request Method: GET
Status Code: 502 Proxy Error
Remote Address: 147.32.80.105:443
Referrer Policy: strict-origin-when-cross-origin
Connection: Keep-Alive
Content-Length: 425
Content-Type: text/html; charset=iso-8859-1
Date: Mon, 09 Nov 2020 11:36:06 GMT
Keep-Alive: timeout=5, max=100
Server: Apache/2.4.25 (Debian)
Accept: */*
Accept-Encoding: gzip, deflate, br
Accept-language: cs
Connection: keep-alive
Host: kbss.felk.cvut.cz
Referer: http://127.0.0.1:3000/
Sec-Fetch-Dest: empty
Sec-Fetch-Mode: cors
Sec-Fetch-Site: cross-site
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.183 Safari/537.36
namespace: https://slovník.gov.cz/datový/pracovní-prostor/pojem/metadatový-kontext/ 

curl https://kbss.felk.cvut.cz/sgov-server/workspaces/instance-1703508316/validate?namespace=https://slovn%C3%ADk.gov.cz/datov%C3%BD/pracovn%C3%AD-prostor/pojem/metadatov%C3%BD-kontext/
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>502 Proxy Error</title>
</head><body>
<h1>Proxy Error</h1>
<p>The proxy server received an invalid
response from an upstream server.<br />
The proxy server could not handle the request<p>Reason: <strong>Error reading from remote server</strong></p></p>
<hr>
<address>Apache/2.4.25 (Debian) Server at kbss.felk.cvut.cz Port 443</address>
</body></html>

@psiotwo
Copy link
Contributor

psiotwo commented Nov 9, 2020

Yes, I confirm, it is a server issue. Moving the ticket to sgov project.

@psiotwo psiotwo transferred this issue from datagov-cz/ontoGrapher Nov 9, 2020
@psiotwo psiotwo added the bug Something isn't working label Nov 9, 2020
@psiotwo psiotwo self-assigned this Nov 9, 2020
psiotwo added a commit that referenced this issue Nov 9, 2020
@psiotwo
[#79] optimizing validations, upgrade spring boot to 2.3.5, cleaning …
7722f2f 
…up logging, upgrading Gradle to 6.7, fixing SHACL tests
psiotwo added a commit that referenced this issue Nov 9, 2020
@psiotwo
Merge pull request #80 from opendata-mvcr/79-validation
94c66d6 
[#79] optimizing validations, upgrade spring boot to 2.3.5, cleaning …
@psiotwo psiotwo linked a pull request Nov 9, 2020 that will close this issue
[#79] optimizing validations, upgrade spring boot to 2.3.5, cleaning … #80
Merged
psiotwo added a commit that referenced this issue Nov 10, 2020
@psiotwo
[#79] revert jb4jsonld to 0.5.1
5e7cbfd
psiotwo added a commit that referenced this issue Nov 10, 2020
@psiotwo
Merge pull request #81 from opendata-mvcr/79-validation
48e30c9 
[#79] revert jb4jsonld to 0.5.1
psiotwo added a commit that referenced this issue Nov 10, 2020
@psiotwo
[#79] revert jopa to 0.14.4
868ad43
psiotwo added a commit that referenced this issue Nov 10, 2020
@psiotwo
[#79] revert jopa to 0.14.4
78c73fb
psiotwo added a commit that referenced this issue Nov 10, 2020
@psiotwo
[#79] revert spring boot to 2.2.6
990b8b3
@psiotwo
Copy link
Contributor

psiotwo commented Nov 10, 2020

@MichalMed please test on main ontographer deploy (for eSbirka the validation still takes 10-20sec).

@MichalMed
Copy link
Contributor Author

It's functional, but results are not good. I see some false violations on the first sight :

  • Částka: Pojem nemá definován (ani odvozen) obsahový typ (Objekt, Vlastnost, Vztah, Událost, nebo jejich typ).
    Actually it is specialization of částka with defined Object type.

  • Podtyp právního aktu : Less than 1 values have shape _:1f0e296d5c92592c165eafc1cf42ca12
    I do not understand why is that wrong (or even what does it mean).

I have experimentally created term with duplicated name. I have got two errors to that. Next to the one, that labels are not ambiguous, I have got (with higher priority) the violation of IRI pojmu není v souladu s názvem pojmu. This is cause by the fact that if you are creating a new term with the existing name, iri is created as label1. I think this behavior is systematically wrong. You shall not be able to create the term in the first place. Even if you are able to do that, yo cannot do anything about the violation, because there is no way how to even see the IRI (not talking about editing it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psiotwo psiotwo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#79] optimizing validations, upgrade spring boot to 2.3.5, cleaning … datagov-cz/sgov
3 participants
@psiotwo @MichalMed @bindeali