This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
Multiselect facets #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the package_search handles fq parameters properly.
Changes the old API search method to ensure that the fq that is set is wrapped in a list.
|
The PR was at ckan#2854 fq_list won't solve the problem because the underlying issue is that when core does finally send the FQ to Solr, it only does so as a string (rather than a list of individual items) and this breaks our usage of tags, so at some point the PR above would be necessary (but slightly modified). |
|
Ok, thanks. Can you see what needs doing on the core ckan PR? It probably needs a test? And it would be good to explain why this PR isn't the same as the core ckan one - I suggest you mark every needed DGU-specific with a comment. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created for issue datagovuk/ckanext-dgu#315
@rossjones did you conclude that this wasn't necessary because adria showed you another way to do it? Otherwise, is there an equivalent PR for core ckan?
Connects to datagovuk/ckanext-dgu#315