Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force strings from stream for the infer strings strategy #115

Merged
merged 2 commits into from
Nov 17, 2019

Conversation

roll
Copy link
Contributor

@roll roll commented Nov 5, 2019


@akariv
Without this change in the load processor, the added test fails which doesn't seem the correct behavior. I also had to update the strategies test. Please take a look at the issue above for more info about where it popped up.

WDYT?

@coveralls
Copy link

coveralls commented Nov 5, 2019

Pull Request Test Coverage Report for Build 401

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 84.623%

Totals Coverage Status
Change from base Build 397: 0.02%
Covered Lines: 1651
Relevant Lines: 1951

💛 - Coveralls

@akariv
Copy link
Member

akariv commented Nov 17, 2019

Yes, this makes sense.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Infer Strategy/Cast Strategy and xlsx files
3 participants