fix permissions of files created with dump_to_path #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduction Steps
open("test.txt", "w").write("Hello World!")
DF.Flow(({'a': 1},{'a': 2}), DF.dump_to_path('test')).process()
Expected
Actual
Explanation
Files created with FileDumper are first created as temporary files which have permissions only for file owner, and are are later copied over to the final location. They are copied with the limited temporary file permissions which is unexpected and limited. This PR fixes it by setting their permissions to the default OS permissions as set by umask.
See more details about this problem and the solution here: https://stackoverflow.com/questions/7150826/how-can-i-get-the-default-file-permissions-in-python