Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): handle docker-compose version v prefix #6561

Merged
merged 1 commit into from
Nov 28, 2022
Merged

fix(ingest): handle docker-compose version v prefix #6561

merged 1 commit into from
Nov 28, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 28, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

jjoyce0510
jjoyce0510 approved these changes Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for fixing so quickly.

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 28, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   56m 19s ⏱️
   765 tests    755 ✔️ 2 💤 1 ❌ 7 🔥
1 532 runs  1 519 ✔️ 5 💤 1 ❌ 7 🔥

For more details on these failures and errors, see this check.

Results for commit 8dd9b24.

@github-actions
Copy link

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   16m 2s ⏱️ +23s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 8dd9b24. ± Comparison against base commit 6eb63c2.

@hsheth2 hsheth2 merged commit 880d042 into datahub-project:master Nov 28, 2022
@hsheth2 hsheth2 deleted the docker-compose-v branch November 28, 2022 21:55
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@hsheth2 @cccs-Dustin
fix(ingest): handle docker-compose version v prefix (datahub-projec…
d038c17 
…t#6561)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @jjoyce0510