feat(ingestion): azure-ad stateful ingestion #7701
Conversation
github-actions
bot
added
the
ingestion
| @@ -529,7 +568,9 @@ def _map_azure_ad_group(self, azure_ad_group): | |||
| self.config.azure_ad_response_to_groupname_regex, | |||
| ) | |||
| if not self.config.groups_pattern.allowed(group_name): | |||
| self.report.report_filtered(f"{corp_group_urn}") | |||
| # lintFix giving error: "StatefulIngestionReport" has no attribute "report_filtered" | |||
There was a problem hiding this comment.
Add a type annotation for the report type in this class. At the top of the class, add report: AzureSourceReport or similar
Do not use type ignore here
| @@ -575,7 +616,9 @@ def _map_azure_ad_users(self, azure_ad_users): | |||
| if error_str is not None: | |||
| continue | |||
| if not self.config.users_pattern.allowed(corp_user_urn): | |||
| self.report.report_filtered(f"{corp_user_urn}.*") | |||
| # lintFix giving error: "StatefulIngestionReport" has no attribute "report_filtered" | |||
| ) | ||
|
|
||
|
|
||
| def stateful_ingest( |
There was a problem hiding this comment.
first, this should be named test_stateful_ingest
second, this looks like a lot of copy-pasted code. could you refactor it to reduce the copying?
There was a problem hiding this comment.
I think that is below.. What if we called this run_ingest_with_state?
Or we refactored into a single run_ingest method?
…iddique/datahub into master+azure-ad-stateful-ingestion
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #7701 +/- ##
==========================================
+ Coverage 74.97% 74.99% +0.01%
==========================================
Files 353 353
Lines 35406 35422 +16
==========================================
+ Hits 26547 26566 +19
+ Misses 8859 8856 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
No description provided.