feat(ingestion/okta): okta stateful ingestion #7736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
siddiquebagwan
commented
Mar 31, 2023
•
siddiquebagwan
commented
- stateful ingestion support in okta connector
- Update doc annotation of Azure AD connector
github-actions
bot
added
the
ingestion
hsheth2
reviewed
Mar 31, 2023
| def get_workunits(self) -> Iterable[MetadataWorkUnit]: | ||
| return auto_stale_entity_removal( | ||
| self.stale_entity_removal_handler, | ||
| auto_workunit_reporter( |
There was a problem hiding this comment.
The auto_workunit_reporter is not appropriate here, but the other two helpers are correct
hsheth2
approved these changes
Apr 4, 2023
hsheth2
requested changes
Apr 4, 2023
metadata-ingestion/src/datahub/ingestion/source/identity/okta.py
Outdated
Show resolved
Hide resolved
hsheth2
approved these changes
Apr 4, 2023
|
@mohdsiddique looks like lint is failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.