Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/json-schema): handle property inheritance in unions #8121

Merged
merged 2 commits into from
May 31, 2023
Merged

fix(ingest/json-schema): handle property inheritance in unions #8121

merged 2 commits into from
May 31, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented May 24, 2023

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2 hsheth2 requested a review from shirshanka May 24, 2023 23:25
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label May 24, 2023
shirshanka
shirshanka approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit a29b576 into datahub-project:master May 31, 2023
@hsheth2 hsheth2 deleted the jsonschema-parser branch February 14, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @shirshanka