Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ingest) Add MetadataChangeProposalWrapper import to example code #8175

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

iprentic
Copy link
Contributor

@iprentic iprentic commented Jun 5, 2023

The code doesn't run as is, need this import as well. Also, change the initialized emitter to the rest emitter to localhost, for continuity with the above curl command, and an example that can run out of the box.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hsheth2
Copy link
Collaborator

hsheth2 commented Jun 5, 2023

@yoonhyejin - lower priority, but it'd be great to move these embedded code blocks into standalone files that are inlined into the docs. That way our linter would catch these sorts of issues in the future

@github-actions github-actions bot added the docs Issues and Improvements to docs label Jun 5, 2023
@iprentic iprentic enabled auto-merge (squash) June 6, 2023 21:27
@iprentic iprentic disabled auto-merge June 7, 2023 16:33
@hsheth2 hsheth2 changed the title docs (ingest) Add MetadataChangeProposalWrapper import to example code docs(ingest) Add MetadataChangeProposalWrapper import to example code Jun 7, 2023
@hsheth2 hsheth2 merged commit b20561a into master Jun 7, 2023
@hsheth2 hsheth2 deleted the nd-metadata-model-docs branch June 7, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues and Improvements to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants