Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ingest/trino): xfail test to unblock CI #8340

Merged
merged 1 commit into from
Jun 30, 2023
Merged

test(ingest/trino): xfail test to unblock CI #8340

merged 1 commit into from
Jun 30, 2023

Conversation

asikowitz
Copy link
Collaborator

There's basically a 0% chance #8339 passes so in the meantime...

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@asikowitz asikowitz changed the title fix(test/trino): xfail test to unblock CI test(ingest/trino): xfail test to unblock CI Jun 29, 2023
hsheth2
hsheth2 approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's make sure to actually fix the underlying issue though

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Jun 29, 2023
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jun 29, 2023
@anshbansal anshbansal merged commit 72a41ef into datahub-project:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asikowitz @hsheth2 @anshbansal