Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(browsepathv2): enable incremental update browsepath #8354

Merged
merged 2 commits into from
Jul 6, 2023
Merged

feat(browsepathv2): enable incremental update browsepath #8354

merged 2 commits into from
Jul 6, 2023

Conversation

david-leifker
Copy link
Collaborator

Additionally use filter over must in filterQuery to avoid scoring impact and ES caching

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment smoke_test Contains changes related to smoke tests labels Jun 30, 2023
@david-leifker
feat(browsepathv2): enable incremental update browsepath
702fd9f 
Additionally use `filter` over `must` in filterQuery to avoid scoring impact and ES caching
@david-leifker david-leifker force-pushed the upgrade-browse-path-incremental branch from 502c0a7 to 702fd9f Compare June 30, 2023 21:19
hsheth2
hsheth2 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smoke tests LGTM

@david-leifker david-leifker merged commit a5f420f into datahub-project:master Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@iprentic iprentic Awaiting requested review from iprentic

@RyanHolstien RyanHolstien Awaiting requested review from RyanHolstien

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-leifker @hsheth2