Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/s3): Fix for flaky s3 test - uploading s3 files in consistent order #8367

Merged
merged 1 commit into from
Jul 4, 2023
Merged

fix(ingest/s3): Fix for flaky s3 test - uploading s3 files in consistent order #8367

merged 1 commit into from
Jul 4, 2023

Conversation

treff7es
Copy link
Contributor

@treff7es treff7es commented Jul 4, 2023

Making sure the order of the uploaded s3 files are always the same in test

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jul 4, 2023
@treff7es treff7es changed the title fix(ingest/s3): Making sure the order of the uploaded s3 files are always the same in test fix(ingest/s3): Making sure the order of the uploaded s3 files order is always the same in the test Jul 4, 2023
@treff7es treff7es changed the title fix(ingest/s3): Making sure the order of the uploaded s3 files order is always the same in the test fix(ingest/s3): Fix for flaky s3 test - uploading s3 files in consistent order Jul 4, 2023
@treff7es treff7es merged commit 74ab1be into datahub-project:master Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treff7es @asikowitz