Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/s3): Deequ import rearragement #8389

Merged
merged 4 commits into from
Jul 10, 2023
Merged

fix(ingest/s3): Deequ import rearragement #8389

merged 4 commits into from
Jul 10, 2023

Conversation

treff7es
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jul 10, 2023
asikowitz
asikowitz approved these changes Jul 10, 2023
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/s3/source.py
@@ -477,6 +476,10 @@ def get_fields(self, table_data: TableData, path_spec: PathSpec) -> List:
def get_table_profile(
self, table_data: TableData, dataset_urn: str
) -> Iterable[MetadataWorkUnit]:
from pydeequ.analyzers import AnalyzerContext
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here or somewhere else discussing why we do relative imports

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Jul 10, 2023
@asikowitz
Copy link
Collaborator

Let's merge once CI finishes to fix CI, then I'll put up a follow up with the comment + removing the pin on pydeequ

@treff7es
Copy link
Contributor Author

Let's merge once CI finishes to fix CI, then I'll put up a follow up with the comment + removing the pin on pydeequ

I already added comments.

@asikowitz asikowitz merged commit e4736d7 into datahub-project:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@treff7es @asikowitz @hsheth2