feat(browsev2): styling updates and select platform #8428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 14, 2023 16:59
jjoyce0510
reviewed
Jul 15, 2023
| @@ -45,12 +45,14 @@ const SearchBody = styled.div` | |||
| overflow: auto; | |||
| `; | |||
|
|
|||
| const ResultContainer = styled.div<{ displayUpdatedStyles: boolean }>` | |||
| const ResultContainer = styled.div<{ v2Styles: boolean }>` | |||
jjoyce0510
reviewed
Jul 17, 2023
| if (count) toggle(); | ||
| }; | ||
|
|
||
| const onClickHeader = () => { | ||
| const isNowSelected = !isPlatformSelectedExact; |
There was a problem hiding this comment.
this variable name is hard to follow... isNowSelected is the opposite of whether the platform alone is selected?
There was a problem hiding this comment.
Eg. is what now selected?
jjoyce0510
reviewed
Jul 17, 2023
| const isPlatformSelected = useIsPlatformSelected(); | ||
| const hasBrowseFilter = useHasFilterField(BROWSE_PATH_V2_FILTER_NAME); | ||
| const isPlatformSelectedPrefix = isPlatformSelected && hasBrowseFilter; | ||
| const isPlatformSelectedExact = isPlatformSelected && !hasBrowseFilter; |
There was a problem hiding this comment.
isPlatformOnlySelected?
There was a problem hiding this comment.
Good suggestion!
jjoyce0510
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Checklist