Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: workarounds for pyyaml installation #8435

Merged
merged 4 commits into from
Jul 17, 2023
Merged

ci: workarounds for pyyaml installation #8435

merged 4 commits into from
Jul 17, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jul 17, 2023 •
edited
Loading

See yaml/pyyaml#601.

  • use wheels for quickstart-compose-validation
  • pin cython in kafka-setup
  • fix airflow builds

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Jul 17, 2023
shirshanka
shirshanka approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsheth2 hsheth2 changed the title ci: use wheels for quickstart-compose-validation ci: workarounds for pyyaml installation Jul 17, 2023
@hsheth2
Copy link
Collaborator Author

hsheth2 commented Jul 17, 2023 •
edited
Loading

Note: merging through the smoke test failures since those are unrelated to this PR, and I want to fix CI

@hsheth2 hsheth2 merged commit 2a3f6c4 into datahub-project:master Jul 17, 2023
@hsheth2 hsheth2 deleted the fix-generate-and-compare branch July 17, 2023 22:26
danielkoh94 added a commit to aqden/datahub that referenced this pull request Sep 5, 2023
@danielkoh94
fix pyyaml dependecies clashing in kafka-setup with reference to pr d…
b1b59ca 
…atahub-project#8435
@danielkoh94 danielkoh94 mentioned this pull request Sep 5, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @shirshanka