Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(browseV2) Escape forward slashes in browse v2 query #8446

Merged
merged 4 commits into from
Jul 21, 2023
Merged

fix(browseV2) Escape forward slashes in browse v2 query #8446

merged 4 commits into from
Jul 21, 2023

Conversation

chriscollins3456
Copy link
Collaborator

We escape forward slashes in our other resolvers that execute search queries - we need to do the same thing in our browseV2 resolver.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jul 18, 2023
joshuaeilers
joshuaeilers approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@joshuaeilers joshuaeilers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast!

@chriscollins3456 chriscollins3456 merged commit 392f9f1 into datahub-project:master Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

@joshuaeilers joshuaeilers joshuaeilers approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriscollins3456 @joshuaeilers @jjoyce0510