fix(ingest): Generate browse paths v2 for more sources; properly pass platform_instance #8501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… platform_instance
5 tasks
asikowitz
commented
Jul 24, 2023
| @@ -139,8 +143,11 @@ def load_lineage_config(file_name: str) -> LineageConfig: | |||
| lineage_config = LineageConfig.parse_obj(config) | |||
| return lineage_config | |||
|
|
|||
| def get_workunits(self) -> Iterable[MetadataWorkUnit]: | |||
| return auto_workunit_reporter(self.report, self.get_workunits_internal()) | |||
| def get_workunit_processors(self) -> List[Optional[MetadataWorkUnitProcessor]]: | |||
There was a problem hiding this comment.
Manually defined here since this is a "file" ingestion source and want to keep the output more constrained. I don't really know how this is used though, so if you think it's better to get all the helpers I'll remove this
| "entityType": "tag", | ||
| "entityUrn": "urn:li:tag:Legacy", | ||
| "changeType": "UPSERT", | ||
| "aspectName": "tagKey", |
There was a problem hiding this comment.
Getting a tag key aspect, just want to make sure this makes sense for this source
hsheth2
approved these changes
Jul 24, 2023
| @@ -2,10 +2,6 @@ | |||
| from dataclasses import dataclass, field | |||
| from typing import Dict, Iterable, List, Optional, Tuple, Type, Union, ValuesView | |||
|
|
|||
| import bson | |||
| import bson.dbref | |||
| import bson.int64 | |||
There was a problem hiding this comment.
Ah I just ran the intellij "optimize imports" command on a bunch of files because they had imports to delete. It's very possible these are needed, we'll see what CI says I guess
github-actions
bot
added
the
ingestion
|
Merged as ingestion tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the following changes:
platform_instanceproperly as per fix(ingest/browsePathv2): fix passing platform instance correctly #8478, thanks @anshbansal!get_workunitsin many sources so that they run workunit processors, which will make them both (i) create status aspects and (ii) create browse paths v2Checklist