fix(ingest): respect max_threads for ingestion reporter #8521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
| @@ -42,7 +42,9 @@ def create( | |||
| elif config_dict is None: | |||
| raise ConfigurationError("Missing provider configuration.") | |||
| else: | |||
| provider_config = DatahubIngestionStateProviderConfig.parse_obj(config_dict) | |||
| provider_config = ( | |||
| DatahubIngestionStateProviderConfig.parse_obj_allow_extras(config_dict) | |||
There was a problem hiding this comment.
@hsheth2, Thank you for the fix! I'm wondering since max_thread is also used in DatahubRestSinkConfig, which I think the one that handles the rest sink, should parse_obj_allow_extras also be called when creating DatahubRestSinkConfig?
There was a problem hiding this comment.
That one actually should be fine as-is, since that class has a max threads option
The main fix here is the removal of that pydantic field removed validator, which was deleting the user provided max threads config before it got parsed
TonyOuyangGit
approved these changes
Jul 28, 2023
asikowitz
approved these changes
Jul 28, 2023
|
Merging through unrelated CI failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack ref: https://datahubspace.slack.com/archives/CUMUWQU66/p1690491969370859
Checklist