Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): bound types-requests #8895

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix(ingest): bound types-requests #8895

merged 1 commit into from
Sep 25, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 25, 2023

We should be able to loosen this once python/typeshed#10764 is fixed. I have a PR up for it: python/typeshed#10776.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 25, 2023
@hsheth2 hsheth2 merged commit 53eaac5 into datahub-project:master Sep 25, 2023
56 of 58 checks passed
@hsheth2 hsheth2 deleted the fix-requests-ci branch September 25, 2023 20:24
@hsheth2
Copy link
Collaborator Author

hsheth2 commented Sep 25, 2023

Merged to unblock CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @asikowitz