Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql): Added datafetcher for DataPlatformInstance entity #8935

Conversation

siladitya2
Copy link
Contributor

@siladitya2 siladitya2 commented Oct 3, 2023

This PR contains below mentioned changes:

  1. Added graphql datafetcher for DataPlatformInstance
  2. Added support for AutoCompletion(autoCompleteForMultiple) of DataPlatformInstanceType.
    The AutoCompletion of DataPlatformInstance will work only if the DATA_PLATFORM_INSTANCE provided on the types of autoCompleteForMultiple query.
    Example:
"input": {
      "query": "big",
      "limit": 10,
      "filters": [],
      "types": ["DATA_PLATFORM_INSTANCE","DATASET"]
    }

We do here the same as searchAcrossEntities, where also DataPlatformInstance will be searched only if DATA_PLATFORM_INSTANCE is included in the types of the query

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 6:22pm

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 3, 2023
@siladitya2 siladitya2 marked this pull request as draft October 3, 2023 14:47
@siladitya2 siladitya2 changed the title feat(grahql): Added datafetcher for DataPlatformInstance entity feat(graphql): Added datafetcher for DataPlatformInstance entity Oct 3, 2023
@siladitya2 siladitya2 marked this pull request as ready for review October 3, 2023 17:30
@jjoyce0510 jjoyce0510 enabled auto-merge (squash) October 11, 2023 00:10
@jjoyce0510 jjoyce0510 merged commit a17db67 into datahub-project:master Oct 11, 2023
34 of 37 checks passed
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants