Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/unity): Use ThreadPoolExecutor for CLL #8952

Merged
merged 3 commits into from
Oct 6, 2023
Merged

feat(ingest/unity): Use ThreadPoolExecutor for CLL #8952

merged 3 commits into from
Oct 6, 2023

Conversation

asikowitz
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

hsheth2
hsheth2 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broadly seems reasonable

assuming the tests are unchanged here, right

metadata-ingestion/src/datahub/ingestion/source/unity/proxy.py Outdated
@@ -45,6 +46,8 @@

logger: logging.Logger = logging.getLogger(__name__)

MAX_WORKERS = 100
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks unused?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, was using this before I added the config param

@asikowitz asikowitz changed the title feat(ingest/unity): Ingest notebooks and their lineage feat(ingest/unity): Use ThreadPoolExecutor for CLL Oct 4, 2023
@asikowitz
Copy link
Collaborator Author

We really need to add some databricks connector tests, if it's to be a high-ish priority source. There's some unit tests but their coverage is not great

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata docs Issues and Improvements to docs labels Oct 4, 2023
@asikowitz asikowitz merged commit c80da8f into datahub-project:master Oct 6, 2023
54 checks passed
@asikowitz asikowitz deleted the databricks-optimize-cll branch October 6, 2023 14:06
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asikowitz @hsheth2 @maggiehays