feat(ingest/teradata): view parsing #9005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort Teradata properly
Addresssing pr review comments
# Conflicts: # metadata-ingestion/docs/sources/teradata/teradata_pre.md # metadata-ingestion/docs/sources/teradata/teradata_recipe.yml # metadata-ingestion/src/datahub/ingestion/source/sql/teradata.py
github-actions
bot
added
the
ingestion
asikowitz
approved these changes
Oct 13, 2023
| @classmethod | ||
| def create(cls, config_dict, ctx): | ||
| config = TeradataConfig.parse_obj(config_dict) | ||
| return cls(config, ctx) | ||
|
|
||
| def get_view_lineage(self) -> Iterable[MetadataWorkUnit]: | ||
| for key in self._view_definition_cache.keys(): | ||
| view_definition = self._view_definition_cache[key] |
There was a problem hiding this comment.
If we want to be safe we should truncate this before putting in the cache, in case it's absurdly large... but I think this is fine for now
Actually, teradata has that query size cap right? Should be safe then
| @@ -221,8 +247,34 @@ def get_metadata_engine(self) -> Engine: | |||
| return create_engine(url, **self.config.options) | |||
|
|
|||
| def get_workunits_internal(self) -> Iterable[Union[MetadataWorkUnit, SqlWorkUnit]]: | |||
| yield from super().get_workunits_internal() | |||
| # Add all schemas to the schema resolver | |||
| for wu in super().get_workunits_internal(): | |||
There was a problem hiding this comment.
Can prob make a helper for this in the future
Comment on lines
+252
to
+269
| if isinstance(wu.metadata, MetadataChangeEventClass): | ||
| if wu.metadata.proposedSnapshot: | ||
| for aspect in wu.metadata.proposedSnapshot.aspects: | ||
| if isinstance(aspect, SchemaMetadataClass): | ||
| self.schema_resolver.add_schema_metadata( | ||
| wu.metadata.proposedSnapshot.urn, | ||
| aspect, | ||
| ) | ||
| break | ||
| if isinstance(wu.metadata, MetadataChangeProposalWrapper): | ||
| if ( | ||
| wu.metadata.entityUrn | ||
| and isinstance(wu.metadata.aspect, ViewPropertiesClass) | ||
| and wu.metadata.aspect.viewLogic | ||
| ): | ||
| self._view_definition_cache[ | ||
| wu.metadata.entityUrn | ||
| ] = wu.metadata.aspect.viewLogic |
There was a problem hiding this comment.
I have a method wu.get_aspect_of_type that we can use in the future
| result = sqlglot_lineage( | ||
| sql=query, | ||
| schema_resolver=self.schema_resolver, | ||
| default_db=None, |
There was a problem hiding this comment.
We should set this right?
maggiehays
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist